Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build by disabling mujoco and moving to newer python patch versions #2220

Merged
merged 15 commits into from May 17, 2021

Conversation

pzhokhov
Copy link
Collaborator

moving to newer python patch versions is necessary to avoid timeouts when pulling docker images for them (somehow, newer images provide better bandwidth? Or maybe old images are not hosted anymore at all?). At the same time, mujoco segfaults on 3.6.13 and 3.7.10. Hence, this PR disables mujoco tests.

@dciborow
Copy link
Contributor

dciborow commented May 4, 2021

please get this in so a new version of gym can go out before i have to pull it from my project....

@dciborow
Copy link
Contributor

dciborow commented May 4, 2021

@joschu , @christopherhesse , I am trying to get a new release of for this PR #2189 , but believe we need reviews from you for this one before a release can be made?

@dciborow
Copy link
Contributor

dciborow commented May 5, 2021

@pzhokhov , we got an ack! Are we able to move forward with release?

@vi3itor
Copy link

vi3itor commented May 14, 2021

@pzhokhov Thank you for the updates! I very much need this PR to be accepted for google-research/football because of the same issue as #2203. Do you need @christopherhesse approval to release a new version?

@dciborow
Copy link
Contributor

@joschu , @pzhokhov ,
Understand this repo is mostly in maintenance mode. My team would rather have an internal fork of this that we can keep secure ourselves. But as I am going to be doing the work regardless, it would actually be even easier for me if I could be an admin in the repo and set up dependabot for the package.
Right now we are still in testing, so this is more of a test case for us then a blocker. But at this point, we aren't sure if we could get real updates out as fast as we need.

Is there any interest in having some help on the build release side of this package so that next time we can roll an update for this out faster?

@pzhokhov pzhokhov merged commit ee5ee3a into master May 17, 2021
@pzhokhov pzhokhov deleted the peterz/fix_build branch May 17, 2021 23:19
@pzhokhov
Copy link
Collaborator Author

pzhokhov commented May 17, 2021

@dciborow thanks for the ping! While external admins could very likely benefit the overall quality of the maintenance of gym, unfortunately, our security team is not comfortable with giving admin access outside the org.

@pzhokhov
Copy link
Collaborator Author

also, released a new version :)

zlig pushed a commit to zlig/gym that referenced this pull request Sep 6, 2021
…ns (openai#2220)

* reverting to older version of 3.6 python to test if the build is failing because of that

* revert 3.7 to 3.7.3 for the build

* revert python 3.8 version to 3.8.1

* do not install mujoco on 3.8 and 3.9

* enable mujoco for 3.7

* .

* .

* .

* use regex to navigate python version dependent package installation

* .

* try only one python version at a time

* switch to possibly more popular python tag for 3.6

* disable mujoco
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants