New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pillow Python Library for CVE-2020-35653 & CVE-2021-27921 #2189
Conversation
Curious to see if any builds pick up a break with this package update. |
Thanks! Why are you pinning Pillow to a specific version? Wouldn't it be better going forward to use Pillow without specifying the version number? Versions before 7.2 worked according to the current |
okay i loosened the pin up. |
@joschu how does this PR look? |
@joschu thanks for the merge! Any chance we can get a 0.18.1 release with this update? My Component Governance system is very angry at my current Pillow version... |
Not sure how to do this. @pzhokhov ? |
typically, this would require simply making a git tag with new version and pushing it, CI would do the rest. However, the build is failing currently, I'll look into fixing it. |
ok so the story is a bit tangled here - the build is broken because we are using relatively old patch versions of python (3.6.8 and 3.7.3); somehow, builds timeout when trying to pull docker images for those. When using newer patch versions that are actually listed on python dockerhub repo page (3.6.13 and 3.7.10), things seem to work, however, then mujoco segfaults. We could move forward without mujoco tests (I made a PR: https://github.com/openai/gym/pull/2220/files), which will let us release newer versions. Otherwise, more investigation is needed into how to make mujoco work with newer versions of python. Thoughts @joschu @christopherhesse ? |
Another approach could be to make our own public mirror for old python images, say, on ACR. OTOH, finicky properties of mujoco wrt python versions are a really sore spot, I'd rather we did not propagate that madness further. |
For the reference, here's how a build that fails to pull python 3.6.8 image from dockerhub looks like: https://www.travis-ci.org/github/openai/gym/jobs/766940827 |
@pzhokhov |
…nai#2189) * Update setup.py * Update setup.py * Update setup.py
No description provided.