Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pillow Python Library for CVE-2020-35653 & CVE-2021-27921 #2189

Merged
merged 3 commits into from Apr 6, 2021

Conversation

dciborow
Copy link
Contributor

No description provided.

@dciborow
Copy link
Contributor Author

Curious to see if any builds pick up a break with this package update.

@dciborow dciborow changed the title Update setup.py Update Pillow Python Library for CVE-2020-35653 Mar 10, 2021
@dciborow
Copy link
Contributor Author

#2174

@dciborow dciborow changed the title Update Pillow Python Library for CVE-2020-35653 Update Pillow Python Library for CVE-2020-35653 & CVE-2021-27921 Mar 10, 2021
@dciborow
Copy link
Contributor Author

@dciborow
Copy link
Contributor Author

dciborow commented Apr 5, 2021

#2203

@danijar
Copy link

danijar commented Apr 5, 2021

Thanks! Why are you pinning Pillow to a specific version? Wouldn't it be better going forward to use Pillow without specifying the version number? Versions before 7.2 worked according to the current setup.py and versions after 7.2 also work according to Travis.

@danijar
Copy link

danijar commented Apr 5, 2021

#2212

@dciborow
Copy link
Contributor Author

dciborow commented Apr 6, 2021

#2199

@dciborow
Copy link
Contributor Author

dciborow commented Apr 6, 2021

okay i loosened the pin up.

@dciborow
Copy link
Contributor Author

dciborow commented Apr 6, 2021

@joschu how does this PR look?

@dciborow
Copy link
Contributor Author

dciborow commented Apr 7, 2021

@joschu thanks for the merge!

Any chance we can get a 0.18.1 release with this update? My Component Governance system is very angry at my current Pillow version...

@joschu
Copy link
Contributor

joschu commented Apr 8, 2021

Not sure how to do this. @pzhokhov ?

@dciborow dciborow deleted the patch-1 branch April 9, 2021 23:35
@pzhokhov
Copy link
Collaborator

Not sure how to do this. @pzhokhov ?

typically, this would require simply making a git tag with new version and pushing it, CI would do the rest. However, the build is failing currently, I'll look into fixing it.

@pzhokhov
Copy link
Collaborator

pzhokhov commented Apr 15, 2021

ok so the story is a bit tangled here - the build is broken because we are using relatively old patch versions of python (3.6.8 and 3.7.3); somehow, builds timeout when trying to pull docker images for those. When using newer patch versions that are actually listed on python dockerhub repo page (3.6.13 and 3.7.10), things seem to work, however, then mujoco segfaults. We could move forward without mujoco tests (I made a PR: https://github.com/openai/gym/pull/2220/files), which will let us release newer versions. Otherwise, more investigation is needed into how to make mujoco work with newer versions of python. Thoughts @joschu @christopherhesse ?

@pzhokhov
Copy link
Collaborator

Another approach could be to make our own public mirror for old python images, say, on ACR. OTOH, finicky properties of mujoco wrt python versions are a really sore spot, I'd rather we did not propagate that madness further.

@pzhokhov
Copy link
Collaborator

For the reference, here's how a build that fails to pull python 3.6.8 image from dockerhub looks like: https://www.travis-ci.org/github/openai/gym/jobs/766940827

@dciborow
Copy link
Contributor Author

dciborow commented May 3, 2021

@pzhokhov
Started getting a lot of safety warnings due to Pillow, and the old pin from gym.
If we can not get a new release up onto pypi, I am going to need to roll gym out of my team's project. Any active work or ETA on 18.0.1?

image

zlig pushed a commit to zlig/gym that referenced this pull request Sep 6, 2021
…nai#2189)

* Update setup.py

* Update setup.py

* Update setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants