Allow custom spaces in VectorEnv #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzhokhov
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
I like this (even though I don't fully agree with the motivation behind strings as custom spaces)! The only thing I would request is adding a comment (maybe in spaces/space.py) along the lines of:
Space class can be subclassed to create a custom observation / action space, however, keep in mind that most cases should be covered by the existing space classes (Box, Discrete, ...) and container space classes (Tuple, Dict). Moreover, parametrized probability distributions and batching functions are only well-defined for the existing spaces, so some learning algorithms may not work out of the box. TLDR think twice before subclassing
pzhokhov
approved these changes
Sep 21, 2020
zlig
pushed a commit
to zlig/gym
that referenced
this pull request
Sep 6, 2021
* Allow custom observation spaces in VectorEnv * Replace np.copy by deepcopy in reset of SyncVectorEnv * Add tests for VectorEnv with custom spaces * Add tests for shared memory and batches of custom spaces * Remove unused import in VectorEnv test * Add warning note in the Space class for custom spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncVectorEnvandSyncVectorEnv. This will not batch the observations, and will return a tuple of individual observations.