Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved performance of simulation #2006

Merged
merged 5 commits into from Sep 25, 2020

Conversation

leocus
Copy link
Contributor

@leocus leocus commented Jul 29, 2020

I reduced the time required for the simulation by using vertex_lists in pyglet

@pzhokhov
Copy link
Collaborator

very cool, thanks! I allowed myself some style changes to match the updated style upstream.
@leocus could you share some numbers about the performance change?
@olegklimov any chance you could take a look and see if the changes make sense to you? I don't know gl well enough to judge that.

@olegklimov
Copy link
Contributor

time required for the simulation

That's cool! How much the render time has improved?

@leocus
Copy link
Contributor Author

leocus commented Sep 3, 2020

On my setup (i5-8250U, 16GB RAM DDR4) i measured those times (over 100 simulations):

  • Original version:
    • Mean: 8.92 s/simulation
    • Std: 0.59 s/simulation
  • This pull request:
    • Mean: 3.84 s/simulation
    • Std: 0.25 s/simulation

@pzhokhov pzhokhov merged commit 81508d3 into openai:master Sep 25, 2020
@xeviknal
Copy link

This PR introduced this nasty memory leak: #2062
A community member created a PR to approach this: #2096

Nice enhancement btw!

@leocus
Copy link
Contributor Author

leocus commented Mar 1, 2021

Sorry about that, glad it has been fixed :)

zlig pushed a commit to zlig/gym that referenced this pull request Sep 6, 2021
* Improved performance of rendering

* Improved performance

* remove commented out line

* black formatting

Co-authored-by: leocus <leocus4@gmail.com>
Co-authored-by: pzhokhov <peterz@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants