Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions with details #560

Closed
joseivanlopez opened this issue May 8, 2023 · 1 comment
Closed

Questions with details #560

joseivanlopez opened this issue May 8, 2023 · 1 comment

Comments

@joseivanlopez
Copy link
Contributor

joseivanlopez commented May 8, 2023

Right now there are two D-Bus interfaces for questions in Agama: org.opensuse.Agama.Questions1.Generic and org.opensuse.Agama.Questions1.LuksActivation. The first one is for very generic questions providing a text and a set of options for answering the question. The other one is very specific to ask for the LUKS encryption password.

Sometimes it is needed to send extra information for a question. For example, the details of a command failure when there is a storage commit error. The current generic iface does not allow to indicate that extra information. Note that having that extra info in a separate D-Bus property is important to allow clients presenting it in a proper way:

There was an error perfoming the following action: Reading partition /dev/vdd2.

command '/usr/bin/udevadm info '/dev/vdd2'' failed:

stderr:
Unknown device "/dev/vdd2": No such device

exit code:
1

Do you want to continue?

[No] [Yes]
This was referenced May 8, 2023
@joseivanlopez
Copy link
Contributor Author

We have changed the D-Bus interfaces for questions and now it uses composition. The use case exposed here can be covered with the current approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant