Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Stop exporting all components #1049

Open
dgdavid opened this issue Feb 22, 2024 · 1 comment
Open

[web] Stop exporting all components #1049

dgdavid opened this issue Feb 22, 2024 · 1 comment

Comments

@dgdavid
Copy link
Contributor

dgdavid commented Feb 22, 2024

TL;DR: rewrote namespace/index.js files for exporting only public components


As discussed at #1045 (comment), right now we're exporting all components via their namespace's index.js file. However, as @joseivanlopez wrotes, it should export the pages and the components that might be reused from pages out of its namespace. The rest should be considered as internal components.

Instead of start diverging the way it is currently done in a single namespace, I've created this issue for addressing all of them at once.

@lslezak
Copy link
Member

lslezak commented May 15, 2024

Note: exporting everything and using the internal components might cause dependency cycles which break hot module replacement. See related #1214 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants