New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Building-rollup] use per output plugins #980
Comments
What's the plan for this? |
Someone needs to dig in and analyze whether this feature can be useful for us. My hope is that we can use the regular plugins entry for shared plugins, and then a per-output plugins for plugins that should run for the different output. That should make it a ton easier to extend the compatibility configuration for our users. This is probably a breaking change, so we should also check whether there are any other pending breaking changes. I might have some soonish, I need to check And maybe @thepassle has some related to the new service worker stuff. |
I dont have any breaking changes planned wrt workbox. It would just be a shared plugin (for both outputs), so I think it can stay where it is |
We discussed this on slack. One use case for use would be something like export default {
output: [
{ dir: 'dist/modern': plugins: [babel({ presets: ['@babel/preset-modules'] })] },
{ dir: 'dist/legacy': plugins: [babel({ presets: ['@babel/preset-env'] })] },
]
// ...
} |
We will need this to be merged rollup/rollup-plugin-babel#333 |
Merged! 😁 |
They didn't release it yet though :/ |
This was implemented in v1 of building-rollup. |
We should use rollup/rollup#3218 when its merged
The text was updated successfully, but these errors were encountered: