Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rollup v3.x.x #2504

Closed
michalica opened this issue Oct 25, 2022 · 9 comments · Fixed by #2649
Closed

Support Rollup v3.x.x #2504

michalica opened this issue Oct 25, 2022 · 9 comments · Fixed by #2649
Labels
enhancement New feature or request

Comments

@michalica
Copy link

Expected behavior

Support for rollup v3 and later

Actual Behavior

Support only v2

Additional context

is there a plan to support rollup v3? I could not find any issue related to this in the repo.

@web-padawan web-padawan added the enhancement New feature or request label Nov 17, 2022
@tirithen
Copy link

tirithen commented Feb 10, 2023

What is the status on Rollup 3 support? The last release of Rollup 2 seem to have been 2.79.1 about 5 months ago, it would be great to be able to keep up while using the open-wc packages.

@web-padawan
Copy link
Contributor

Unfortunately, most of us are busy with other projects at the moment. We would need to get together to discuss this.

Personally, I don't have much experience with Rollup internals, although I'd love to learn more and dive into the topic.
But without proper plan and at least some tentative agreement on what to do, I don't know how to approach this.

@daKmoR @LarsDenBakker @thepassle @Westbrook @43081j would you be ok to have a call on Rollup 3 plans?

@thepassle
Copy link
Member

Support rollup v3 in what, exactly? Is anything particularly blocked on not using rollup v3? The breaking changes in rollup v3 are very minimal, most things should just kind of work with it.

@web-padawan
Copy link
Contributor

I'm mostly talking about Web Dev Server and its internals (that also affect Web Test Runner), there are some issues there.
Especially this one modernweb-dev/web#1700 is basically a blocker for newer versions of @rollup/plugin-commonjs.

@thepassle
Copy link
Member

Im confused, those are modern web projects (not open-wc) and those dont necessarily have anything to do with updating to rollup v3?

@43081j
Copy link
Contributor

43081j commented Feb 10, 2023

I'm mostly talking about Web Dev Server and its internals (that also affect Web Test Runner), there are some issues there. Especially this one modernweb-dev/web#1700 is basically a blocker for newer versions of @rollup/plugin-commonjs.

even older versions are broken now afaik. the commonjs support in modernweb is extremely lacking, probably due to the mw team not using commonjs themselves anymore i suspect.

Im confused, those are modern web projects (not open-wc) and those dont necessarily have anything to do with updating to rollup v3?

pretty sure its meant to be a modernweb issue.

dropping openwc and moving everything into modernweb would solve such confusions, just saying :D

also happy to collab/discuss on whatever support might be needed

@web-padawan
Copy link
Contributor

I'd be happy to transfer the issue but looks like it can't be done across different GitHub organisations. Let me create a new one instead.

@svanherk
Copy link
Contributor

I'm mostly talking about Web Dev Server and its internals (that also affect Web Test Runner), there are some issues there.

It looks like these now require rollup v3 as of Friday:
https://github.com/modernweb-dev/web/releases/tag/%40web%2Fdev-server%400.2.0
https://github.com/modernweb-dev/web/releases/tag/%40web%2Ftest-runner%400.16.0

When I try to use the new versions above with @open-wc/building-rollup, @web/dev-server and @web/test-runner will install their own local copies of rollup.

@Westbrook @koddsson I noticed #2663, will the rollup version also be bumped as part of the upcoming release?

@koddsson
Copy link
Member

@Westbrook @koddsson I noticed #2663, will the rollup version also be bumped as part of the upcoming release?

That's the plan! See #2649 by @Westbrook for the actual change. #2663 was a PR to that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants