-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symlinks provided as globs are not working #172
Comments
I hit this by working in a repository that was using pnpm workspaces, such that I have multiple node_module directories and some packages in the children are symlinks to the root level node_modules, with the symlinks managed by pnpm. The error I get is
and the node_modules directory looks like
notice that the module it is failing on is because is because while it may exclude the current directory's node_module directory, it doesn't exclude the files that are in |
Checklist
--dev
flag to get more information?Hello there,
at first, thank you for this project. It did a really good job for me in the past and I hope to see it having a good future :)
I noticed some flaws while using symlinks within the provided globs. The analyzer seems to ignore symlinks, e.g. the ones used by pnpm. A minimal demo project is located here - I'm afraid I wasn't able to simulate this error on the Nelify playground but I think the repository should help.
You can install the dependencies using
pnpm install
. After that, a working script which doesn't use symlinks and a malfunctioning script which uses symlinks that analyze the same files are provided in thepackages/analyze-project
.At a first look I thought this had something to do with Chokidar, but it seems that they have an
followSymlinks
option activated by default. So I don't really know what to look for now. If you have any ideas on how this can be fixed - I'm happy to help :)Working manifest
Not working manifest
The text was updated successfully, but these errors were encountered: