Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to Go getting-started example #4490

Merged
merged 6 commits into from
May 16, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented May 15, 2024

Resolve open-telemetry/opentelemetry-go#5058

cc @open-telemetry/go-approvers

@MrAlias MrAlias requested review from a team as code owners May 15, 2024 16:14
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit comment.

content/en/docs/languages/go/getting-started.md Outdated Show resolved Hide resolved
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we mark that logger part is experimental? @open-telemetry/docs-maintainers, if so can you give a proposal how to add a good notice?

@svrnm

This comment was marked as resolved.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyedits. Otherwise, LGTM. I'll let other check the code.

content/en/docs/languages/go/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/languages/go/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/languages/go/getting-started.md Outdated Show resolved Hide resolved
@svrnm svrnm merged commit c1126f1 into open-telemetry:main May 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dice example to use logs
5 participants