Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing FQN for common resource attributes #4330

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add missing FQN for common resource attributes #4330

wants to merge 5 commits into from

Conversation

cartermp
Copy link
Contributor

fixes #4328

@cartermp cartermp requested review from a team as code owners April 20, 2024 15:09
zeitlinger
zeitlinger requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@zeitlinger zeitlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now deprecated: https://github.com/open-telemetry/semantic-conventions-java/blob/9202fd6cdc1b21e05558d17b6f13608345a3f80b/semconv/src/main/java/io/opentelemetry/semconv/ServiceAttributes.java#L15

@theletterf
Copy link
Member

Should this be closed then?

@zeitlinger
Copy link
Member

Should this be closed then?

I added a suggestion.
The import is still wrong though.

cartermp and others added 3 commits April 26, 2024 15:19
@zeitlinger
Copy link
Member

@theletterf I now have an alternative suggestion:

we can move the example code to https://github.com/open-telemetry/opentelemetry-java-examples and then embed the example code using code_excerpter.

See #4276

I'm happy to help 😄

@theletterf
Copy link
Member

Nice! Could you try that in a draft PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeitlinger zeitlinger zeitlinger requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
sig:java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exporters example does not compile: SERVICE_NAME and SERVICE_VERSION are not defined.
3 participants
@cartermp @theletterf @zeitlinger