Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that log attributes are NOT standard attributes #3849

Closed
pellared opened this issue Jan 30, 2024 · 2 comments · Fixed by #3852
Closed

Clarify that log attributes are NOT standard attributes #3849

pellared opened this issue Jan 30, 2024 · 2 comments · Fixed by #3852
Assignees
Labels
spec:logs Related to the specification/logs directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal

Comments

@pellared
Copy link
Member

pellared commented Jan 30, 2024

What are you trying to achieve?

Currently, logs attributes are different from standard (resource, trace, metrics) attributes.
However, there may be a desire to make unify them as some languages already use standard attributes for defining log attributes.

I want to have clarification that log attributes are distinct from standard attributes before stabilizing OTel Go Bridge API.

My proposal is to explicitly call out that log attributes are different.

Additional context.

Follow-up to: #2888 (comment)

Prior PRs:

There seem to be no consensus whether the standard attributes should be expanded to support complex types.

I don't believe we'll reach a consensus on limiting log attributes to only accommodate types defined by standard attributes. This would be also a breaking specification change.

I also want to point out that the Bridge API does anyway require the ability to support complex types for log record body. Therefore, the log attributes can be defined using the types used for modelling body.

Moreover, OTLP already supports complex types for attributes so there is no technical need to limit the log attribute values.

Related issues:

@pellared pellared added the spec:logs Related to the specification/logs directory label Jan 30, 2024
@trask
Copy link
Member

trask commented Jan 30, 2024

I don't believe we'll reach a consensus on limiting log attributes to only accommodate types defined by common attributes. This would be also a breaking specification change.

Deprecation would be an option

@pellared
Copy link
Member Author

pellared commented Jan 30, 2024

SIG meeting notes:

It may sense to have log attributes to be modeled differently than standard attributes as the purpose of Logs Bridge API is to support what existing structured logging libraries offer. Some applications use complex values for attributes and end-users would like to keep them.

The Event API may (to be discussed) restrict the attributes and accept only standard attributes.

The semantic conventions should use only standard (non-complex) attributes.

@jack-berg jack-berg added the triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal label Feb 14, 2024
@pellared pellared changed the title Clarify that log attributes are NOT common attributes Clarify that log attributes are NOT standard attributes Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:logs Related to the specification/logs directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal
Projects
None yet
4 participants