Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the definition of state #2623

Closed
codeboten opened this issue Jun 20, 2022 · 1 comment · Fixed by #2663
Closed

Improve the definition of state #2623

codeboten opened this issue Jun 20, 2022 · 1 comment · Fixed by #2663
Assignees
Labels
area:semantic-conventions Related to semantic conventions enhancement New feature or request spec:metrics Related to the specification/metrics directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal

Comments

@codeboten
Copy link
Contributor

What are you trying to achieve?

Currently the definition for the state attribute of the system.network.connections metric really only applies to TCP connections. It should either be defined in a way that makes it meaningful to multiple protocols or the metric should be separated per protocol.

Additional context.

This issue is a follow up to the discussion here: #2617 (comment)

@codeboten codeboten added the spec:metrics Related to the specification/metrics directory label Jun 20, 2022
@arminru arminru added area:semantic-conventions Related to semantic conventions enhancement New feature or request labels Jun 21, 2022
@reyang reyang added the triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal label Jun 24, 2022
@rbailey7210
Copy link

This a good suggestion. Thank you for the recommendation. It is accepted.

codeboten pushed a commit to codeboten/opentelemetry-specification that referenced this issue Jul 14, 2022
Replacing wikipedia link with set values for the state. I would add that the states listed here only apply to TCP protocol, which reinforces my thinking that the system.network.connections metric should be split by protocol. Asking reviewers to consider this. If folks agree, I will open a follow up PR to mark `system.network.connections` as deprecated in favour of `system.network.tcp.connections` and `system.network.udp.connections`.

Fixes open-telemetry#2623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions enhancement New feature or request spec:metrics Related to the specification/metrics directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal
Projects
None yet
5 participants