Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup external-otlp examples #872

Merged
merged 1 commit into from Sep 5, 2022

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Sep 4, 2022

  • Fix comment header to use simpler language
  • Fix comment header to refer to correct binary
  • Coalesce use statements
  • Update env_logger to 0.9.0
  • ensure that both examples are formatted the same

@DavidS DavidS requested a review from a team as a code owner September 4, 2022 19:10
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Base: 66.8% // Head: 66.8% // No change to project coverage 👍

Coverage data is based on head (480b60c) compared to base (0e6e67e).
Patch has no changes to coverable lines.

❗ Current head 480b60c differs from pull request most recent head da29067. Consider uploading reports for the commit da29067 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #872   +/-   ##
=====================================
  Coverage   66.8%   66.8%           
=====================================
  Files        113     113           
  Lines       8775    8775           
=====================================
  Hits        5866    5866           
  Misses      2909    2909           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

* Fix comment header to use simpler language
* Fix comment header to refer to correct binary
* Coalesce use statements
* Update env_logger to 0.9.0
* ensure that both examples are formatted the same
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@jtescher jtescher merged commit a57993c into open-telemetry:main Sep 5, 2022
@DavidS DavidS deleted the external-otlp-examples branch September 6, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants