Fix span processor exporting unsampled spans #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently span processors will send span data to exporters even if the sampled flag is false. This patch fixes this by explicitly checking the sampled state in both the batch and simple span processors.
Codecov ReportBase: 66.8% // Head: 66.6% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
=======================================
- Coverage 66.8% 66.6% -0.2%
=======================================
Files 113 113
Lines 8775 8798 +23
=======================================
- Hits 5866 5864 -2
- Misses 2909 2934 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TommyCpp
reviewed
Sep 3, 2022
|
@TommyCpp added a regression test 👍 |
TommyCpp
approved these changes
Sep 6, 2022
|
Sorry took a look yesterday but forgot to approve |
|
@TommyCpp All good, thanks for the review 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently span processors will send span data to exporters even if the sampled flag is false. This patch fixes this by explicitly checking the sampled state in both the batch and simple span processors.
Fixes #870