New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add with_batch_processor_config for jaeger pipline #869
Feat: add with_batch_processor_config for jaeger pipline #869
Conversation
Codecov ReportBase: 66.6% // Head: 66.7% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
=======================================
+ Coverage 66.6% 66.7% +0.1%
=======================================
Files 113 113
Lines 8727 8776 +49
=======================================
+ Hits 5813 5859 +46
- Misses 2914 2917 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Please take a look. @TommyCpp |
Thanks for working on it! It overall looks good to me. The msrv issue should be resolved once you merge the latest main branches. |
Signed-off-by: zengxilong <zengxilonglh@gmail.com>
Signed-off-by: zengxilong <zengxilonglh@gmail.com>
76a41e0
to
37e2591
Compare
I rabase on master, but MSRV issue still exists |
Signed-off-by: zengxilong <zengxilonglh@gmail.com>
37e2591
to
18d258b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks 👍 Just a small nit
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
It's resolved, thanks for the review. |
PR for #842