Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add with_batch_processor_config for jaeger pipline #869

Conversation

zengxilong
Copy link
Contributor

@zengxilong zengxilong commented Aug 30, 2022

PR for #842

  1. add set functions to set BatchConfig
  2. add set_batch_config to HasRequiredConfig trait for all jaeger pipeline
  3. add with_batch_processor_config for all jaeger pipline

@zengxilong zengxilong requested a review from a team as a code owner August 30, 2022 06:22
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 30, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 66.6% // Head: 66.7% // Increases project coverage by +0.1% 🎉

Coverage data is based on head (76a41e0) compared to base (9ea1ee7).
Patch coverage: 95.8% of modified lines in pull request are covered.

❗ Current head 76a41e0 differs from pull request most recent head 616ec40. Consider uploading reports for the commit 616ec40 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #869     +/-   ##
=======================================
+ Coverage   66.6%   66.7%   +0.1%     
=======================================
  Files        113     113             
  Lines       8727    8776     +49     
=======================================
+ Hits        5813    5859     +46     
- Misses      2914    2917      +3     
Impacted Files Coverage Δ
opentelemetry-jaeger/src/exporter/config/mod.rs 75.5% <ø> (ø)
opentelemetry-jaeger/src/exporter/config/agent.rs 60.5% <88.8%> (+2.5%) ⬆️
...emetry-jaeger/src/exporter/config/collector/mod.rs 58.2% <88.8%> (+1.7%) ⬆️
opentelemetry-sdk/src/trace/span_processor.rs 81.9% <100.0%> (+1.8%) ⬆️
opentelemetry-jaeger/src/lib.rs 93.0% <0.0%> (-0.4%) ⬇️
...aeger/src/exporter/config/collector/http_client.rs 22.5% <0.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zengxilong
Copy link
Contributor Author

Please take a look. @TommyCpp

@TommyCpp
Copy link
Contributor

TommyCpp commented Sep 1, 2022

Thanks for working on it! It overall looks good to me. The msrv issue should be resolved once you merge the latest main branches.

@zengxilong zengxilong force-pushed the feature/zengxilong_add_batchConfig_for_jaeger_pipline branch from 76a41e0 to 37e2591 Compare September 1, 2022 09:12
@zengxilong
Copy link
Contributor Author

I rabase on master, but MSRV issue still exists

Signed-off-by: zengxilong <zengxilonglh@gmail.com>
@zengxilong zengxilong force-pushed the feature/zengxilong_add_batchConfig_for_jaeger_pipline branch from 37e2591 to 18d258b Compare September 1, 2022 09:30
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 👍 Just a small nit

Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
@zengxilong
Copy link
Contributor Author

zengxilong commented Sep 1, 2022

LGTM! Thanks 👍 Just a small nit

It's resolved, thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants