Fix XrayPropagator when no header is present #867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects an issue where using
XrayPropagator
without thex-amzn-trace-id
trace header present would cause spans not to get logged/processed.Background
My use case is in a project that combines
tracing
,tracing-opentelemetry
,opentelemetry
, andopentelemetry-jaeger
.I initially had everything working, but when I added the
XrayPropagator
I noticed that my spans were no longer appearing in jaeger when I made requests directly to my service. I then switched toTraceContextPropagator
and everything worked again.This change simply copies the logic used in
TraceContextPropagator
intoXrayPropagator
.I tested it in my local project and confirmed that with this change traces without a parent are still appearing in
jaeger
.