Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): clippy issues raised by 1.63 #862

Merged
merged 5 commits into from Aug 14, 2022

Conversation

TommyCpp
Copy link
Contributor

  • Fix issues raised by 1.63 stable
  • Fix issues raised by 1.63 nightly
  • collector_password should take &self

@TommyCpp TommyCpp force-pushed the rustc-1.63 branch 2 times, most recently from 2253fa4 to fa5bbf2 Compare August 13, 2022 23:10
@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #862 (d8eb98b) into main (8df4f49) will decrease coverage by 2.2%.
The diff coverage is 43.9%.

@@           Coverage Diff           @@
##            main    #862     +/-   ##
=======================================
- Coverage   68.8%   66.6%   -2.3%     
=======================================
  Files        115     113      -2     
  Lines       9371    8727    -644     
=======================================
- Hits        6455    5813    -642     
+ Misses      2916    2914      -2     
Impacted Files Coverage Δ
opentelemetry-api/src/metrics/instruments/gauge.rs 0.0% <0.0%> (ø)
...try-api/src/metrics/instruments/up_down_counter.rs 0.0% <0.0%> (ø)
opentelemetry-dynatrace/src/lib.rs 46.6% <ø> (ø)
opentelemetry-http/src/lib.rs 7.5% <0.0%> (-4.8%) ⬇️
opentelemetry-jaeger/src/exporter/agent.rs 13.7% <ø> (+1.2%) ⬆️
opentelemetry-jaeger/src/exporter/runtime.rs 0.0% <ø> (ø)
opentelemetry-sdk/src/export/metrics/stdout.rs 0.0% <0.0%> (ø)
opentelemetry-sdk/src/metrics/aggregators/mod.rs 70.0% <ø> (ø)
opentelemetry-sdk/src/testing/metric.rs 0.0% <0.0%> (ø)
opentelemetry/src/lib.rs 100.0% <ø> (ø)
... and 75 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TommyCpp TommyCpp marked this pull request as ready for review August 13, 2022 23:41
@TommyCpp TommyCpp requested a review from a team as a code owner August 13, 2022 23:41
@TommyCpp TommyCpp merged commit c92a1ad into open-telemetry:main Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants