Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpanExporter::ForceFlush and default implementation #845

Merged

Conversation

ymtdzzz
Copy link
Contributor

@ymtdzzz ymtdzzz commented Jul 19, 2022

Add SpanExporter::ForceFlush, and default implementation not to affect existing Exporters.

Fixes #836

@ymtdzzz ymtdzzz requested a review from a team as a code owner July 19, 2022 12:59
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #845 (7d5ad92) into main (b3e6e6a) will increase coverage by 0.1%.
The diff coverage is 80.0%.

@@           Coverage Diff           @@
##            main    #845     +/-   ##
=======================================
+ Coverage   68.7%   68.8%   +0.1%     
=======================================
  Files        115     115             
  Lines       9346    9371     +25     
=======================================
+ Hits        6427    6456     +29     
+ Misses      2919    2915      -4     
Impacted Files Coverage Δ
opentelemetry-api/src/trace/context.rs 49.1% <ø> (ø)
opentelemetry-jaeger/src/exporter/collector.rs 20.0% <0.0%> (+0.1%) ⬆️
opentelemetry-sdk/src/export/trace/mod.rs 82.3% <0.0%> (-17.7%) ⬇️
opentelemetry-sdk/src/trace/tracer.rs 90.6% <0.0%> (ø)
opentelemetry-sdk/src/trace/sampler.rs 95.8% <100.0%> (+2.4%) ⬆️
opentelemetry-api/src/trace/tracer.rs 66.6% <0.0%> (+5.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae00d34...7d5ad92. Read the comment docs.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ymtdzzz

@jtescher jtescher merged commit f7bbbdd into open-telemetry:main Jul 23, 2022
@ymtdzzz ymtdzzz deleted the feature/spanexporter-forceflush branch July 24, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpanExporter::ForceFlush
2 participants