Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Custom Samplers #833

Merged
merged 1 commit into from Jul 16, 2022
Merged

Conversation

hdost
Copy link
Contributor

@hdost hdost commented Jul 7, 2022

This adds the ability for users to combine custom samplers with the built-in Parent-Based Sampler.

@hdost hdost force-pushed the feat/should-sample branch 2 times, most recently from cb09274 to 09bae09 Compare July 8, 2022 10:54
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #833 (3b20f08) into main (b3e6e6a) will increase coverage by 0.1%.
The diff coverage is 96.0%.

@@           Coverage Diff           @@
##            main    #833     +/-   ##
=======================================
+ Coverage   68.7%   68.9%   +0.1%     
=======================================
  Files        115     115             
  Lines       9346    9369     +23     
=======================================
+ Hits        6427    6461     +34     
+ Misses      2919    2908     -11     
Impacted Files Coverage Δ
opentelemetry-sdk/src/trace/tracer.rs 90.6% <0.0%> (ø)
opentelemetry-sdk/src/trace/sampler.rs 95.8% <100.0%> (+2.4%) ⬆️
opentelemetry-jaeger/src/exporter/mod.rs 53.9% <0.0%> (+2.6%) ⬆️
opentelemetry-api/src/trace/tracer.rs 66.6% <0.0%> (+5.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e6e6a...3b20f08. Read the comment docs.

Relates open-telemetry#800

Signed-off-by: Harold Dost <h.dost@criteo.com>
@hdost hdost marked this pull request as ready for review July 15, 2022 12:41
@hdost hdost requested a review from a team as a code owner July 15, 2022 12:41
@jtescher jtescher merged commit 63b7350 into open-telemetry:main Jul 16, 2022
@hdost hdost deleted the feat/should-sample branch July 17, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants