Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup pin-project dep #830

Merged
merged 3 commits into from Jul 16, 2022

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Jul 1, 2022

@matklad matklad requested a review from a team as a code owner July 1, 2022 11:46
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 1, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: matklad / name: Aleksey Kladov (2f6a82a)

@matklad
Copy link
Contributor Author

matklad commented Jul 1, 2022

You might want to check this setting:

image

to make sure that PRs get tested. At the moment, I am seeing this:

image

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@matklad
Copy link
Contributor Author

matklad commented Jul 1, 2022

hopefully fixed compilation error

* remove pin-project from crates which weren't actually using it
* switch to pin-project-lite to improve compilation time and impose
  fewer deps at consumers (ecosystem migrated to -lite awhile ago
  tokio-rs/tokio#1778)
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #830 (8a74207) into main (b3e6e6a) will increase coverage by 1.0%.
The diff coverage is 33.3%.

❗ Current head 8a74207 differs from pull request most recent head 010bdbf. Consider uploading reports for the commit 010bdbf to get more accurate results

@@           Coverage Diff           @@
##            main    #830     +/-   ##
=======================================
+ Coverage   68.7%   69.8%   +1.0%     
=======================================
  Files        115     111      -4     
  Lines       9346    9195    -151     
=======================================
- Hits        6427    6420      -7     
+ Misses      2919    2775    -144     
Impacted Files Coverage Δ
opentelemetry-api/src/trace/context.rs 50.0% <ø> (+0.8%) ⬆️
opentelemetry-jaeger/src/exporter/collector.rs 20.0% <0.0%> (+0.1%) ⬆️
...ntelemetry-sdk/src/metrics/aggregators/ddsketch.rs 76.9% <100.0%> (ø)
opentelemetry-sdk/src/metrics/controllers/push.rs 80.0% <0.0%> (-3.4%) ⬇️
opentelemetry-zipkin/src/exporter/model/mod.rs 80.3% <0.0%> (-1.2%) ⬇️
opentelemetry-datadog/src/lib.rs 86.8% <0.0%> (-0.8%) ⬇️
opentelemetry-api/src/metrics/noop.rs 36.0% <0.0%> (-0.7%) ⬇️
opentelemetry-jaeger/src/exporter/config/agent.rs 57.4% <0.0%> (-0.6%) ⬇️
opentelemetry-api/src/baggage.rs 84.5% <0.0%> (-0.6%) ⬇️
opentelemetry-jaeger/src/lib.rs 92.5% <0.0%> (-0.5%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b7350...010bdbf. Read the comment docs.

@matklad
Copy link
Contributor Author

matklad commented Jul 1, 2022

fixed the clippy error -- seems unrelated, prob just new rust version.

@TommyCpp
Copy link
Contributor

TommyCpp commented Jul 1, 2022

You might want to check this setting:

image

to make sure that PRs get tested. At the moment, I am seeing this:

image

Thanks for bring it up. I think it's a opentelemetry org level setting for security reasons.

@matklad
Copy link
Contributor Author

matklad commented Jul 1, 2022

Is it currently set to "require approval for all outside collaborators" or "require approval for first time contributors"?

If it is the former, than, yes, this is an explicit setting for security reasons.

If it is the latter, than this is most likely just a stupid GitHub default which they added in an ad-hoc manner when folks started abusing github actions to mine crypto.

@TommyCpp
Copy link
Contributor

TommyCpp commented Jul 1, 2022

If it is the latter, than this is most likely just a stupid GitHub default which they added in an ad-hoc manner when folks started abusing github actions to mine crypto.

Yeah I think you are right. We are not given full access of the repo so I cannot check the actual setting. But from what I have seen it's the case. open-telemetry/community#1023 also mentioned it. I will open a issue to ask TC change it for us.

@jtescher
Copy link
Member

jtescher commented Jul 4, 2022

Looks good, just the lint remaining

@TommyCpp
Copy link
Contributor

TommyCpp commented Jul 16, 2022

The nightly version seems to be broken now
rust-lang/rust#99343

We can probably merge this as it is

@jtescher jtescher merged commit ab7bce3 into open-telemetry:main Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants