Update metrics API and SDK #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change would have been nicer in smaller pieces, but many of them rely on each other. |
ptescher
approved these changes
Jun 21, 2022
jtescher
force-pushed
the
metrics-update
branch
3 times, most recently
from
6228f84
to
c5fd910
Compare
This change aligns metrics with the spec, changes include: * Rename `MeterProvider::meter` to `MeterProvider::versioned_meter` for consistency with `TracerProvider` trait. * Move metrics sdk api types to `opentelemetry-sdk` * Consolidate instrument builders into `InstrumentBuilder` * Remove value observers and add gauges. * Move from batch observer to registered callbacks. * Rename `ExportKindFor` to `TemporalitySelector` * Consolidate `PushController` and `PullController` into `BasicController` * Remove `MinMaxSumCountAggregator` and `ArrayAggregator` * Update examples and exporters for new api/sdk
|
cc @hdost |
|
for the #733 I think this looks good, However I do wonder if we might want to also add some convenience methods, could be in a followup PR of allowing users to not need to always pass the context. I can open up a separate ticket for this. I'm sure from a performance perspective passing the Context is more performant. |
|
Although seeing this #828 it's possible this, perhaps there's some further research to be done on ensuring it's working as expected ingeneral. |
|
Sorry I have been busy moving. Will try to take a look today |
TommyCpp
reviewed
Jun 29, 2022
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns metrics with the spec, changes include:
MeterProvider::metertoMeterProvider::versioned_meterforconsistency with
TracerProvidertrait.opentelemetry-sdkInstrumentBuilderExportKindFortoTemporalitySelectorPushControllerandPullControllerintoBasicControllerMinMaxSumCountAggregatorandArrayAggregatorResolves #733