Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msrv: bump from 1.49 to 1.55 #811

Merged
merged 1 commit into from Jun 21, 2022
Merged

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Jun 13, 2022

@TommyCpp TommyCpp marked this pull request as ready for review June 13, 2022 02:23
@TommyCpp TommyCpp requested a review from a team as a code owner June 13, 2022 02:23
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #811 (cff2427) into main (3806258) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #811   +/-   ##
=====================================
  Coverage   69.8%   69.8%           
=====================================
  Files        110     110           
  Lines       9072    9072           
=====================================
+ Hits        6334    6337    +3     
+ Misses      2738    2735    -3     
Impacted Files Coverage Δ
opentelemetry-api/src/lib.rs 100.0% <ø> (ø)
opentelemetry-jaeger/src/lib.rs 93.0% <ø> (ø)
opentelemetry-zipkin/src/lib.rs 100.0% <ø> (ø)
opentelemetry/src/lib.rs 100.0% <ø> (ø)
opentelemetry-http/src/lib.rs 7.0% <0.0%> (-5.3%) ⬇️
opentelemetry-jaeger/src/exporter/mod.rs 54.0% <0.0%> (+3.0%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3806258...cff2427. Read the comment docs.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may still want to support 1.49 as many people integrate via tracing https://github.com/tokio-rs/tracing/tree/master/tracing#supported-rust-versions

@jtescher
Copy link
Member

Which changes would we need to revert to continue supporting 1.49?

@TommyCpp
Copy link
Contributor Author

TommyCpp commented Jun 14, 2022

Which changes would we need to revert to continue supporting 1.49?

The bump was introduced by #799. I think alternatively we can rewrite part of the indexmap to avoid the bump.

Although Tokio ecosystem promise 6-month compatibility. 1.55 was released in Sep 2021 so it's still consistent with that promise.

Any thoughts?

@jtescher
Copy link
Member

Nvm we could open an issue to bump tracing as well, but probably simpler to retain 1.49 support if we can't get that in.

@TommyCpp
Copy link
Contributor Author

but probably simpler to retain 1.49 support if we can't get that in.

I will give it a try! I will merge this for now so that we can maintain at least 1.55 MSRV when building the new PRs. The current one in main branch breaks our MSRV promise.

@TommyCpp TommyCpp merged commit e33859f into open-telemetry:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants