Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace): jaeger remote sampler #797

Merged
merged 14 commits into from Jul 4, 2022

Conversation

TommyCpp
Copy link
Contributor

fix #606.

Add initial implementation of jaeger remote sampler

@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #797 (f4aac81) into main (103ed3a) will decrease coverage by 1.0%.
The diff coverage is 26.2%.

@@           Coverage Diff           @@
##            main    #797     +/-   ##
=======================================
- Coverage   69.8%   68.7%   -1.1%     
=======================================
  Files        111     115      +4     
  Lines       9196    9402    +206     
=======================================
+ Hits        6420    6466     +46     
- Misses      2776    2936    +160     
Impacted Files Coverage Δ
opentelemetry-http/src/lib.rs 12.2% <ø> (ø)
...etry-sdk/src/trace/sampler/jaeger_remote/remote.rs 0.0% <0.0%> (ø)
...try-sdk/src/trace/sampler/jaeger_remote/sampler.rs 0.0% <0.0%> (ø)
...c/trace/sampler/jaeger_remote/sampling_strategy.rs 0.0% <0.0%> (ø)
opentelemetry-sdk/src/trace/sampler.rs 93.4% <72.2%> (-4.0%) ⬇️
...-sdk/src/trace/sampler/jaeger_remote/rate_limit.rs 83.0% <83.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103ed3a...f4aac81. Read the comment docs.

@TommyCpp TommyCpp marked this pull request as ready for review May 16, 2022 00:12
@TommyCpp TommyCpp requested a review from a team as a code owner May 16, 2022 00:12
@TommyCpp
Copy link
Contributor Author

TommyCpp commented Jun 5, 2022

cc @open-telemetry/rust-approvers if someone could take a look 👻

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice to support this one 👍

@jtescher jtescher merged commit 703059a into open-telemetry:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add jaeger remote sampler to SDK configuration
2 participants