Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v0.18.0 release #779

Merged
merged 9 commits into from Sep 12, 2022
Merged

Prepare for v0.18.0 release #779

merged 9 commits into from Sep 12, 2022

Conversation

jtescher
Copy link
Member

@jtescher jtescher commented Apr 10, 2022

See VERSIONING.md for what is being stabilized.

@jtescher jtescher requested a review from a team as a code owner April 10, 2022 18:43
@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Base: 66.6% // Head: 66.6% // No change to project coverage 👍

Coverage data is based on head (09cab12) compared to base (6c1e487).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #779   +/-   ##
=====================================
  Coverage   66.6%   66.6%           
=====================================
  Files        113     113           
  Lines       8783    8783           
=====================================
  Hits        5850    5850           
  Misses      2933    2933           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djc
Copy link
Contributor

djc commented Apr 11, 2022

Hm, not sure if this is a good idea. The way Cargo version resolution, it considers pre-releases semver-compatible with other pre-releases for the same release. Thus, if you release this and there would later be a 1.0.0-beta.2 with any semver-incompatible changes in it, you would break all downstream users.

@jtescher
Copy link
Member Author

@djc good point, is there a better beta convention?

@djc
Copy link
Contributor

djc commented Apr 11, 2022

Hmm, can't think of anything that's widely used in the Rust ecosystem. What is the point of calling it beta? I'd probably just bump the minor version and communicate the status against the spec in the release notes.

@TommyCpp
Copy link
Contributor

+1 on release using 0.x version and adding notes to communicate this is a beta 1.0 release. Also, I don't think the VERSIONING.md is clear about what we are stabilizing(should only be the trace feature). Maybe need to add that to the release note?

@jtescher jtescher changed the title Prepare for 1.0.0-beta.1 release Prepare for v0.18.0 release Apr 17, 2022
@TommyCpp
Copy link
Contributor

Do we want to wait for #781 as it has an API change?

@djc
Copy link
Contributor

djc commented Apr 21, 2022

Do we want to wait for #781 as it has an API change?

I think that would make sense.

@jwilm
Copy link
Contributor

jwilm commented Jun 23, 2022

Any chance this will land soon? We are eagerly awaiting the new version. 😄

@jtescher
Copy link
Member Author

Should be soon hopefully, just have to resolve the MSRV issues on main

# Conflicts:
#	opentelemetry-api/Cargo.toml
#	opentelemetry-aws/Cargo.toml
#	opentelemetry-contrib/Cargo.toml
#	opentelemetry-datadog/Cargo.toml
#	opentelemetry-http/Cargo.toml
#	opentelemetry-jaeger/Cargo.toml
#	opentelemetry-sdk/Cargo.toml
#	opentelemetry-stackdriver/Cargo.toml
@jtescher
Copy link
Member Author

jtescher commented Jul 9, 2022

@open-telemetry/rust-approvers should we wait for the current open PRs to land? or merge this sooner than that.

@TommyCpp
Copy link
Contributor

TommyCpp commented Jul 9, 2022

I think we should include #833 as it includes a fairly important fix for sampling IMO

@hdost
Copy link
Contributor

hdost commented Jul 12, 2022

I'll make sure to get that finished , theres also a change in the samplers which I can adjust there as well.

# Conflicts:
#	opentelemetry-dynatrace/Cargo.toml
#	opentelemetry-jaeger/CHANGELOG.md
#	opentelemetry-jaeger/Cargo.toml
#	opentelemetry-sdk/CHANGELOG.md
#	opentelemetry-stackdriver/Cargo.toml
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🚢!

@jtescher
Copy link
Member Author

@djc need a 👍 to merge 😄

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳️

@jtescher jtescher merged commit 2e1de57 into open-telemetry:main Sep 12, 2022
@jtescher jtescher deleted the relase branch September 12, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants