Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: unify Event and Link access patterns #757

Merged
merged 1 commit into from Mar 12, 2022

Conversation

jtescher
Copy link
Member

This makes the data in span Events and Links pub, but guards against future additions by making the structs non_exhaustive.

This makes the data in span `Event`s and `Link`s `pub`, but guards
against future additions by making the structs `non_exhaustive`.
@jtescher jtescher requested a review from a team as a code owner March 12, 2022 18:44
@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #757 (9977aa6) into main (027c1f8) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   70.22%   70.21%   -0.02%     
==========================================
  Files         108      108              
  Lines        8804     8795       -9     
==========================================
- Hits         6183     6175       -8     
+ Misses       2621     2620       -1     
Impacted Files Coverage Δ
opentelemetry-jaeger/src/exporter/mod.rs 59.76% <0.00%> (ø)
opentelemetry-api/src/trace/mod.rs 78.72% <100.00%> (+1.93%) ⬆️
opentelemetry-api/src/trace/tracer.rs 61.03% <100.00%> (ø)
opentelemetry-sdk/src/trace/span.rs 93.65% <100.00%> (ø)
opentelemetry-http/src/lib.rs 7.01% <0.00%> (-5.27%) ⬇️
opentelemetry-sdk/src/metrics/controllers/push.rs 83.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027c1f8...9977aa6. Read the comment docs.

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Was there a particular motivation for doing this now?

@jtescher
Copy link
Member Author

Trying to get all the api changes needed before 1.0 release

@jtescher jtescher merged commit 45a0626 into open-telemetry:main Mar 12, 2022
@jtescher jtescher deleted the link-data branch March 12, 2022 21:35
vibhavp pushed a commit to vibhavp/opentelemetry-rust that referenced this pull request Mar 14, 2022
This makes the data in span `Event`s and `Link`s `pub`, but guards
against future additions by making the structs `non_exhaustive`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants