api: make TraceStateError priviate
#755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the error handling in the `trace` module by making `TraceStateError` private, and exposing these errors as the more general `TraceError`.
jtescher
force-pushed
the
remove-trace-state-error
branch
from
24d7f78
to
424be37
Compare
Codecov Report
@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 70.22% 70.21% -0.02%
==========================================
Files 108 108
Lines 8804 8807 +3
==========================================
+ Hits 6183 6184 +1
- Misses 2621 2623 +2
Continue to review full report at Codecov.
|
TommyCpp
approved these changes
Mar 12, 2022
|
Sure, could do in a follow up. |
vibhavp
pushed a commit
to vibhavp/opentelemetry-rust
that referenced
this pull request
Mar 14, 2022
This change simplifies the error handling in the `trace` module by making `TraceStateError` private, and exposing these errors as the more general `TraceError`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the error handling in the
tracemodule by makingTraceStateErrorprivate, and exposing these errors as the more generalTraceError.