fix(sdk): meter_with_version should accept optional parameter for optional parameters.
#752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptional parameters.
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
==========================================
+ Coverage 70.19% 70.22% +0.03%
==========================================
Files 108 108
Lines 8804 8804
==========================================
+ Hits 6180 6183 +3
+ Misses 2624 2621 -3
Continue to review full report at Codecov.
|
jtescher
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #743
BREAKING CHANGES:
meter_with_versionwill not accpet Optional as 2nd and 3rd parameters