Remove Tracer::with_span
#746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is not part of the trace spec and the same functionality can be achieved with `mark_span_as_active` or `Context::current_with_span(span).attach()`.
jtescher
force-pushed
the
remove-tracer-with-span
branch
from
e34840c
to
f9c3728
Compare
TommyCpp
approved these changes
Feb 28, 2022
|
Need to fix the doc link issue found in |
Codecov Report
@@ Coverage Diff @@
## main #746 +/- ##
==========================================
+ Coverage 70.08% 70.11% +0.02%
==========================================
Files 108 108
Lines 8789 8789
==========================================
+ Hits 6160 6162 +2
+ Misses 2629 2627 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is not part of the trace spec and the same functionality can be achieved with
mark_span_as_activeorContext::current_with_span(span).attach().