Move IdGenerator to SDK, rename RandomIdGenerator
#742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [spec] defines `IdGenerator` as part of the SDK. This also renames the default generator to match other language implementations in calling the default id generator `RandomIdGenerator`. [spec]: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.9.0/specification/trace/sdk.md#id-generators
Codecov Report
@@ Coverage Diff @@
## main #742 +/- ##
=======================================
Coverage 70.12% 70.12%
=======================================
Files 108 108
Lines 8789 8789
=======================================
Hits 6163 6163
Misses 2626 2626
Continue to review full report at Codecov.
|
TommyCpp
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec defines
IdGeneratoras part of the SDK. This also renames the default generator to match other language implementations in calling the default id generatorRandomIdGenerator.