New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull sampling probability from env var #737
Pull sampling probability from env var #737
Conversation
|
Hi 👋 Thanks for the contribution. We are currently avoiding using Also, you can run |
7c73589
to
66f9039
Compare
@TommyCpp thanks for the tips. This should be good but i can't run the CI ! |
Codecov Report
@@ Coverage Diff @@
## main #737 +/- ##
==========================================
- Coverage 71.54% 70.12% -1.43%
==========================================
Files 102 108 +6
Lines 8611 8806 +195
==========================================
+ Hits 6161 6175 +14
- Misses 2450 2631 +181
Continue to review full report at Codecov.
|
c2ee2a6
to
8715175
Compare
…he default sdk config Signed-off-by: jbtrystram <jbtrystram@redhat.com>
8715175
to
20917dd
Compare
Pull sampling probability from env var
OTEL_TRACES_SAMPLER_ARG
in the default sdk configI could not find an enum with the expected values strings, so I hard coded them in there, if I missed the file please let me know !
Tho whomever may review this : The spec states the following :
this why I added some calls to
log
but it looks like no logger is initialized. Should I add a logger to the crate ? Thanks for your guidanceSigned-off-by: jbtrystram jbtrystram@redhat.com