Deprecate ValueRecorder in favor of Histogram #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdost
force-pushed
the
deprecate-value-recorder
branch
4 times, most recently
from
0c930a1
to
aa9fa19
Compare
Codecov Report
@@ Coverage Diff @@
## main #728 +/- ##
=======================================
Coverage 71.50% 71.50%
=======================================
Files 102 102
Lines 8593 8593
=======================================
Hits 6144 6144
Misses 2449 2449
Continue to review full report at Codecov.
|
hdost
force-pushed
the
deprecate-value-recorder
branch
4 times, most recently
from
3cacf46
to
747739f
Compare
|
@TommyCpp I know the codecov are optional is it ok in this case since it's bascially just replacing a type? |
Yeah, don't worry about it especially for -0.02% changes |
TommyCpp
reviewed
Feb 11, 2022
hdost
force-pushed
the
deprecate-value-recorder
branch
from
747739f
to
0a91a9c
Compare
TommyCpp
approved these changes
Feb 13, 2022
The Metric API Spec is now stable and ValueRecorder was replaced with Histogram. * Deprecations - left structs unmarked as clippy threw a fit. * Update all code examples to use Histograms. * Remove InstrumentKind::ValueRecorder since it's not part of the API. ** Otherwise we were left with duplicating code int the SDK which does exactly the same thing. Signed-off-by: Harold Dost <github@hdost.com>
hdost
force-pushed
the
deprecate-value-recorder
branch
from
0a91a9c
to
c3fc589
Compare
|
Only change was a rebase |
|
Looks good. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Metric API Spec is now stable and ValueRecorder was replaced with
Histogram.