Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stackdriver: avoid calling log from inside exporter #709

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

djc
Copy link
Contributor

@djc djc commented Jan 20, 2022

Rebased #705.

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #709 (7035862) into main (6d07ff0) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
+ Coverage   71.36%   71.38%   +0.01%     
==========================================
  Files         101      101              
  Lines        8557     8557              
==========================================
+ Hits         6107     6108       +1     
+ Misses       2450     2449       -1     
Impacted Files Coverage Δ
opentelemetry/src/sdk/metrics/controllers/push.rs 83.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d07ff0...7035862. Read the comment docs.

@jtescher jtescher merged commit a81c6c6 into open-telemetry:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants