Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stackdriver: further improvements #703

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

djc
Copy link
Contributor

@djc djc commented Jan 12, 2022

  • Avoid spawning inside the library
  • Use a concrete error type
  • Generate protobuf bindings in a test (avoids build script + dependencies, makes generated code visible to the IDE)

@djc djc requested a review from a team as a code owner January 12, 2022 19:18
@djc djc force-pushed the stackdriver-tweaks branch 2 times, most recently from c6ef229 to dbedba3 Compare January 12, 2022 19:34
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #703 (c873824) into main (0d116a0) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   71.39%   71.40%   +0.01%     
==========================================
  Files         101      101              
  Lines        8564     8564              
==========================================
+ Hits         6114     6115       +1     
+ Misses       2450     2449       -1     
Impacted Files Coverage Δ
opentelemetry/src/sdk/metrics/controllers/push.rs 83.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d116a0...c873824. Read the comment docs.

@TommyCpp TommyCpp merged commit 605d6c0 into open-telemetry:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants