Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stackdriver: implement writing log entries #702

Merged
merged 7 commits into from
Jan 11, 2022

Conversation

djc
Copy link
Contributor

@djc djc commented Jan 11, 2022

Also includes a bunch of refactoring to make the code easier to follow.

@djc djc requested a review from a team as a code owner January 11, 2022 15:16
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #702 (84889cd) into main (abd4943) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
+ Coverage   71.36%   71.40%   +0.03%     
==========================================
  Files         101      101              
  Lines        8564     8564              
==========================================
+ Hits         6112     6115       +3     
+ Misses       2452     2449       -3     
Impacted Files Coverage Δ
opentelemetry-http/src/lib.rs 12.28% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd4943...84889cd. Read the comment docs.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtescher jtescher merged commit 0d116a0 into open-telemetry:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants