Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add InstrumentationLibrary to should_sample parameters. #695

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Jan 5, 2022

fix #616.

@TommyCpp TommyCpp requested a review from a team as a code owner January 5, 2022 05:24
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #695 (05c1b10) into main (0d13190) will decrease coverage by 0.02%.
The diff coverage is 84.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   71.41%   71.39%   -0.03%     
==========================================
  Files         101      101              
  Lines        8551     8564      +13     
==========================================
+ Hits         6107     6114       +7     
- Misses       2444     2450       +6     
Impacted Files Coverage Δ
opentelemetry/src/sdk/trace/span.rs 93.55% <62.50%> (-2.02%) ⬇️
opentelemetry/src/sdk/trace/tracer.rs 91.08% <97.22%> (+0.31%) ⬆️
opentelemetry/src/sdk/trace/sampler.rs 93.10% <100.00%> (+0.12%) ⬆️
opentelemetry/src/sdk/metrics/controllers/push.rs 80.00% <0.00%> (-3.34%) ⬇️
opentelemetry-http/src/lib.rs 12.28% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a914409...05c1b10. Read the comment docs.

@jtescher jtescher merged commit 9f3abed into open-telemetry:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instrumentation libraty to should_sample
2 participants