sdk: optimize span creation internals #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch from `Option::map` to pattern match in sdk tracer: ~16% perf improvement on span creation. * optimize for common case of single span processor in sdk span: ~1% perf improvement on span end Overall improvement on span start-end benchmark: ~17%
Codecov Report
@@ Coverage Diff @@
## main #693 +/- ##
==========================================
- Coverage 71.41% 71.39% -0.03%
==========================================
Files 101 101
Lines 8551 8561 +10
==========================================
+ Hits 6107 6112 +5
- Misses 2444 2449 +5
Continue to review full report at Codecov.
|
djc
reviewed
Jan 4, 2022
djc
reviewed
Jan 5, 2022
djc
reviewed
Jan 9, 2022
djc
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option::mapto pattern match in sdk tracer: ~16% perf improvement on span creation.Overall improvement on span start-end benchmark: ~17%