trace: switch to parent context references #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates `Tracer::start_with_context` to accepet a reference instead of an owned parent `Context`, and adds `Tracer::build_with_context` to allow a parent context reference to be passed with a builder as well. This also removes the need for `SpanBuilder`s to store a context.
Codecov Report
@@ Coverage Diff @@
## main #687 +/- ##
==========================================
- Coverage 63.81% 63.73% -0.08%
==========================================
Files 96 96
Lines 7725 7708 -17
==========================================
- Hits 4930 4913 -17
Misses 2795 2795
Continue to review full report at Codecov.
|
djc
approved these changes
Jan 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Tracer::start_with_contextto accepet a reference instead of an owned parentContext, and addsTracer::build_with_contextto allow a parent context reference to be passed with a builder as well. This also removes the need forSpanBuilders to store a context.