Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace: remove unused Tracer::invalid method #683

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

jtescher
Copy link
Member

This method is not part of the trace spec and is not currently being used in a meaningful way.

@jtescher jtescher requested a review from a team as a code owner December 23, 2021 19:05
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #683 (72de1f9) into main (457556b) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   63.76%   63.85%   +0.09%     
==========================================
  Files          95       95              
  Lines        7733     7717      -16     
==========================================
- Hits         4931     4928       -3     
+ Misses       2802     2789      -13     
Impacted Files Coverage Δ
opentelemetry/src/global/trace.rs 22.95% <ø> (+0.72%) ⬆️
opentelemetry/src/sdk/trace/tracer.rs 91.00% <ø> (+3.07%) ⬆️
opentelemetry/src/trace/tracer.rs 67.50% <ø> (ø)
opentelemetry/src/trace/noop.rs 75.25% <100.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457556b...72de1f9. Read the comment docs.

@jtescher jtescher merged commit ec40cd4 into open-telemetry:main Dec 23, 2021
@jtescher jtescher deleted the remove-invalid branch December 23, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants