Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TraceState::valid_key crashes #665

Merged
merged 1 commit into from
Nov 6, 2021
Merged

fix: TraceState::valid_key crashes #665

merged 1 commit into from
Nov 6, 2021

Conversation

DCjanus
Copy link
Contributor

@DCjanus DCjanus commented Nov 6, 2021

fix #650

@DCjanus DCjanus requested a review from a team as a code owner November 6, 2021 11:38
@codecov
Copy link

codecov bot commented Nov 6, 2021 •
edited

Codecov Report

Merging #665 (3b5dbfe) into main (2d37fd1) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   62.22%   62.37%   +0.15%     
==========================================
  Files          95       95              
  Lines        7738     7751      +13     
==========================================
+ Hits         4815     4835      +20     
+ Misses       2923     2916       -7
Impacted Files Coverage Δ
opentelemetry/src/trace/span_context.rs 91.69% <100.00%> (+2.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d37fd1...3b5dbfe. Read the comment docs.

djc
djc approved these changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TommyCpp TommyCpp merged commit 1f2a075 into open-telemetry:main Nov 6, 2021
@DCjanus DCjanus deleted the fix-trace-state-valid-key branch November 6, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] TraceState::valid_key crashes
3 participants
@DCjanus @djc @TommyCpp