Allow static str and string in span methods #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #654 +/- ##
=======================================
Coverage ? 62.13%
=======================================
Files ? 95
Lines ? 7719
Branches ? 0
=======================================
Hits ? 4796
Misses ? 2923
Partials ? 0
Continue to review full report at Codecov.
|
Improves performance and ergonomics by allowing `&'static str` or `String` types to be passed to span methods. Also clarifies the intention behind the object safe trait variants in the global trace module.
jtescher
force-pushed
the
cow-span-methods
branch
from
b0c49bc
to
5933477
Compare
This was referenced Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance and ergonomics by allowing
&'static strorStringtypes to be passed to span methods. Also clarifies the intention behind the object safe trait variants in the global trace module.