Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default resource detection for tracer provider #641

Merged
merged 11 commits into from
Oct 7, 2021

Conversation

srikanthccv
Copy link
Member

Spec says

The SDK MUST extract information from the OTEL_RESOURCE_ATTRIBUTES environment variable and merge this, as the secondary resource, with any resource information provided by the user, i.e. the user provided resource information has higher priority.

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #641 (7c271e5) into main (542c28a) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
+ Coverage   61.98%   62.08%   +0.10%     
==========================================
  Files          95       95              
  Lines        7683     7705      +22     
==========================================
+ Hits         4762     4784      +22     
  Misses       2921     2921              
Impacted Files Coverage Δ
opentelemetry/src/sdk/resource/mod.rs 87.38% <ø> (ø)
opentelemetry/src/sdk/trace/provider.rs 84.82% <100.00%> (+2.86%) ⬆️
opentelemetry/src/sdk/trace/span_processor.rs 82.18% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 542c28a...7c271e5. Read the comment docs.

@srikanthccv srikanthccv marked this pull request as ready for review September 29, 2021 16:37
@srikanthccv srikanthccv requested a review from a team as a code owner September 29, 2021 16:37
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! really love the unit tests.

@TommyCpp
Copy link
Contributor

TommyCpp commented Oct 3, 2021

@jtescher Any more comments or it's good to merge?

@jtescher
Copy link
Member

jtescher commented Oct 3, 2021

@TommyCpp one last issue to resolve one way or the other

@TommyCpp TommyCpp merged commit 980e185 into open-telemetry:main Oct 7, 2021
@srikanthccv srikanthccv deleted the otel-env-detect branch October 7, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants