Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_attributes method for Span #638

Merged
merged 1 commit into from Apr 17, 2022

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Sep 27, 2021

This adds the convenience method set_attributes for set multiple attributes.

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #638 (9797bbe) into main (a474268) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #638   +/-   ##
=====================================
  Coverage   69.8%   69.9%           
=====================================
  Files        109     109           
  Lines       8912    8927   +15     
=====================================
+ Hits        6226    6240   +14     
- Misses      2686    2687    +1     
Impacted Files Coverage Δ
opentelemetry-api/src/trace/context.rs 46.4% <ø> (ø)
opentelemetry-api/src/trace/span.rs 100.0% <100.0%> (ø)
opentelemetry-sdk/src/trace/span.rs 93.6% <100.0%> (+0.1%) ⬆️
opentelemetry-sdk/src/metrics/controllers/push.rs 80.0% <0.0%> (-3.4%) ⬇️
opentelemetry-otlp/src/span.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a474268...9797bbe. Read the comment docs.

@srikanthccv srikanthccv marked this pull request as ready for review September 27, 2021 04:03
@srikanthccv srikanthccv requested a review from a team as a code owner September 27, 2021 04:03
@srikanthccv srikanthccv marked this pull request as draft November 2, 2021 05:28
This adds the convenience method `Span::set_attributes` to set multiple
attributes at a time.

Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
@jtescher jtescher marked this pull request as ready for review April 10, 2022 17:34
@jtescher jtescher merged commit 74d0c2d into open-telemetry:main Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants