Implement Serialize & Deserialize for more stuff #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecton
force-pushed
the
impl-serialize-deserialize-for-span-limits
branch
from
52dd6f9
to
c0bf04b
Compare
Codecov Report
@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 61.97% 61.96% -0.01%
==========================================
Files 95 95
Lines 7681 7682 +1
==========================================
Hits 4760 4760
- Misses 2921 2922 +1
Continue to review full report at Codecov.
|
cecton
changed the title
cecton
commented
Sep 1, 2021
| @@ -214,12 +214,15 @@ pub use crate::exporter::{ | |||
| use opentelemetry::sdk::export::ExportError; | |||
|
|
|||
| #[cfg(feature = "grpc-sys")] | |||
| pub use crate::exporter::grpcio::GrpcioExporterBuilder; | |||
| pub use crate::exporter::grpcio::{Compression, Credentials, GrpcioExporterBuilder}; | |||
There was a problem hiding this comment.
There are a few things to say here:
- They should probably be prefixed with
Grpcioas they are specific to that exporter - They were public but not accessible. There was no way to call
with_compressionorwith_credentialsbecause the types couldn't be instantiated. In the doc you can see it because the types are not clickable:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same than #622 but for: