fix: HistogramAggregator returns sum when asked for count #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtescher
approved these changes
Dec 27, 2020
jan-xyz
added a commit
to jan-xyz/opentelemetry-rust
that referenced
this pull request
Oct 1, 2021
0.13.0 Bug fix: Avoid panics from Instant::elapsed (open-telemetry#406) Improvement: Allow trailing comma on macros (open-telemetry#390) Improvement: Add macros for custom registry (open-telemetry#396) Improvement: Export thread count from process_collector (open-telemetry#401) Improvement: Add convenience TextEncoder functions to encode directly to string (open-telemetry#402) Internal change: Clean up the use of macro_use and extern crate (open-telemetry#398) Internal change: Update dependencies
TommyCpp
added a commit
that referenced
this pull request
Oct 5, 2021
* bump prometheus dependency to 0.13 0.13.0 Bug fix: Avoid panics from Instant::elapsed (#406) Improvement: Allow trailing comma on macros (#390) Improvement: Add macros for custom registry (#396) Improvement: Export thread count from process_collector (#401) Improvement: Add convenience TextEncoder functions to encode directly to string (#402) Internal change: Clean up the use of macro_use and extern crate (#398) Internal change: Update dependencies * also update in example Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find this bug when testing the otlp metric exporter. We still might need to add more tests around metrics. But I think this should fix the problem.