Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use InstrumentationLibrary in metrics. #393

Conversation

TommyCpp
Copy link
Contributor

Currently we don't use InstrumentationLibrary to store the instrumentation library information. This should help unify things a little bit. My only concern is whether there will be any cases that users cannot use static string as argument(need to fetch intrumentation information somewhere else). So far I haven't thought any, so leave it as it is for now.

Currently we don't use InstrumentationLibrary to store the instrumentation library information. This commit switch to use that.
@codecov
Copy link

codecov bot commented Dec 19, 2020

Codecov Report

Merging #393 (4f4066d) into master (47b54ee) will increase coverage by 0.00%.
The diff coverage is 52.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   49.31%   49.31%           
=======================================
  Files          66       66           
  Lines        5368     5376    +8     
=======================================
+ Hits         2647     2651    +4     
- Misses       2721     2725    +4     
Impacted Files Coverage Δ
opentelemetry/src/api/metrics/observer.rs 0.00% <ø> (ø)
opentelemetry/src/api/metrics/registry.rs 0.00% <0.00%> (ø)
opentelemetry/src/api/metrics/config.rs 20.68% <11.11%> (-1.90%) ⬇️
opentelemetry/src/api/metrics/descriptor.rs 33.33% <60.00%> (+3.10%) ⬆️
opentelemetry/src/api/metrics/meter.rs 50.00% <66.66%> (-2.64%) ⬇️
opentelemetry/src/global/metrics.rs 83.33% <71.42%> (-16.67%) ⬇️
opentelemetry/src/api/metrics/noop.rs 20.00% <100.00%> (ø)
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 76.95% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b54ee...4f4066d. Read the comment docs.

@jtescher
Copy link
Member

Yeah I think requiring the static lifetime is fine here

@TommyCpp TommyCpp marked this pull request as ready for review December 20, 2020 21:57
@TommyCpp TommyCpp requested a review from a team as a code owner December 20, 2020 21:57
@TommyCpp
Copy link
Contributor Author

Yeah I think requiring the static lifetime is fine here

👍 We can also switch to the owned string if someone brings a valid use case and that shouldn't break existing APIs.

@jtescher jtescher merged commit 1bcbe77 into open-telemetry:master Dec 21, 2020
@TommyCpp TommyCpp deleted the tommycpp/instrumentation-library-metrics branch March 10, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants