Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instrumentation version for instrument config. #392

Merged

Conversation

TommyCpp
Copy link
Contributor

Working on the otel metrics exporter. Think we should include instrumentation version in metrics as we did in tracing.

@TommyCpp TommyCpp requested a review from a team as a code owner December 18, 2020 03:11
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #392 (415affd) into master (4390213) will decrease coverage by 0.09%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   49.42%   49.32%   -0.10%     
==========================================
  Files          66       66              
  Lines        5356     5368      +12     
==========================================
+ Hits         2647     2648       +1     
- Misses       2709     2720      +11     
Impacted Files Coverage Δ
opentelemetry/src/api/metrics/config.rs 22.58% <16.66%> (-9.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4390213...415affd. Read the comment docs.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jtescher jtescher merged commit 47b54ee into open-telemetry:master Dec 18, 2020
@TommyCpp TommyCpp deleted the tommycpp/instrumentation-version branch December 19, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants