Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate Resource from Span to proto (Tonic) #386

Closed
markdingram opened this issue Dec 16, 2020 · 2 comments
Closed

Propagate Resource from Span to proto (Tonic) #386

markdingram opened this issue Dec 16, 2020 · 2 comments
Assignees
@markdingram

Comments

@markdingram
Copy link
Contributor

The excellent change to add Tonic in #352 didn't inherit the fix to populate Resource from the Span to proto from #366

Will provide a PR unless something is already in the works?
@jtescher
Copy link
Member

Ah yeah looks like that one got missed, PRs appreciated 👍

markdingram added a commit to markdingram/opentelemetry-rust that referenced this issue Dec 17, 2020
@markdingram
Propagate Resource from Span to proto (Tonic) (open-telemetry#386)
be3cf8c
jtescher pushed a commit that referenced this issue Dec 17, 2020
@markdingram
Propagate Resource from Span to proto (Tonic) (#386) (#390)
41fdac6
markdingram added a commit to markdingram/opentelemetry-rust that referenced this issue Dec 17, 2020
@markdingram
Propagate Resource from Span to proto (Tonic) (open-telemetry#386)
1e5c5a5
markdingram added a commit to markdingram/opentelemetry-rust that referenced this issue Dec 17, 2020
@markdingram
Propagate Resource from Span to proto (Tonic) (open-telemetry#386)
26b9ac1
jtescher pushed a commit that referenced this issue Dec 18, 2020
@markdingram
Propagate Resource from Span to proto (Tonic) (#386) (#391)
4390213
@markdingram
Copy link
Contributor Author

this was merged in 4390213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markdingram markdingram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtescher @markdingram