Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
opentelemetry
andopentelemetry-contrib
to report traces to Datadog, I noticed that all spans are marked as errors by default. I was able to correct this by manually callingspan.set_status(StatusCode::Ok, ...)
, but I have since learned that the expectation (which the docs support) is that the default should beOk
instead.This change updates the ordering to make
Ok
the default, and updates tests in the Datadog encoder to reflect this change.