Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects span StatusCode ordering #377

Merged
merged 2 commits into from Dec 10, 2020

Conversation

willroberts
Copy link
Contributor

When using opentelemetry and opentelemetry-contrib to report traces to Datadog, I noticed that all spans are marked as errors by default. I was able to correct this by manually calling span.set_status(StatusCode::Ok, ...), but I have since learned that the expectation (which the docs support) is that the default should be Ok instead.

This change updates the ordering to make Ok the default, and updates tests in the Datadog encoder to reflect this change.

@willroberts willroberts requested a review from a team as a code owner December 9, 2020 19:15
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 9, 2020

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #377 (9a262e1) into master (5192fba) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   49.32%   49.34%   +0.01%     
==========================================
  Files          66       66              
  Lines        5326     5326              
==========================================
+ Hits         2627     2628       +1     
+ Misses       2699     2698       -1     
Impacted Files Coverage Δ
opentelemetry/src/api/trace/span.rs 64.51% <ø> (ø)
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 76.95% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5192fba...9a262e1. Read the comment docs.

@willroberts
Copy link
Contributor Author

I've completed the CLA! Merge at your convenience :)

@jtescher jtescher merged commit b444b25 into open-telemetry:master Dec 10, 2020
@willroberts willroberts deleted the fix-status-codes branch December 14, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants