Move 3rd party propagators and merge exporter into sdk::export #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 53.93% 49.13% -4.81%
==========================================
Files 71 66 -5
Lines 6081 5326 -755
==========================================
- Hits 3280 2617 -663
+ Misses 2801 2709 -92
Continue to review full report at Codecov.
|
|
Hm yeah I think it may be more intuitive to have the jaeger / be propagators with the exporters in their crates rather than contrib. |
jtescher
approved these changes
Dec 5, 2020
Also updated proto
…into move � Conflicts: � opentelemetry-otlp/src/lib.rs � opentelemetry-otlp/src/span.rs
jtescher
reviewed
Dec 6, 2020
TommyCpp
commented
Dec 6, 2020
| @@ -129,3 +129,7 @@ See the [code owners](CODEOWNERS) file. | |||
|
|
|||
| See the [community membership document in OpenTelemetry community | |||
| repo](https://github.com/open-telemetry/community/blob/master/community-membership.md). | |||
|
|
|||
| ## FAQ | |||
| ### Where should I put third party propagators/exporters, contrib or standalone crates? | |||
There was a problem hiding this comment.
wanted to clarify the problem that where to put the stuff here. Please let me know if the below descriptions makes sense. @jtescher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #361
Fix #340
This PR:
opentelemetry-contrib/propagatortestingfeature so that we could share test util between crates.exporterintosdk::exportopentelemetry-protoUpgrade note:
awspropagators. Addopentelemetry-contribin yourCargo.toml. Choose the feature based on the propagators you need and import them viaopentelemetry_contrib::trace::propagators::<propagators name>.exportermodule. Such asExportError. Change the import path fromopentelemetry::exporterintoopentelemetry::sdk::exportjaegerpropagators. Addopentelemetry-jaegerin yourCargo.toml. useopentelemetry_jaeger::Propagatorb3propagators. Addopentelemetry-zipkinin yourCargo.toml. useopentelemetry_zipkin::PropagatorOpen question(s):
Where should we put theMoved zipkin and jaeger propagators into their own crate.jaegerandb3propagtor? It's intutive to me that we include them as part of theopentelemetry-jaegeroropentelemetry-zipkincrate. But Go impl put it incontrib